Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add elgato 1.19.0 #1039

Merged
merged 1 commit into from
Aug 28, 2024
Merged

add elgato 1.19.0 #1039

merged 1 commit into from
Aug 28, 2024

Conversation

Kincekara
Copy link
Collaborator

Just updated the program version:

diff elgato/1.18.2/Dockerfile elgato/1.19.0/Dockerfile
3c3
< ARG ELGATO_VER="1.18.2"
---
> ARG ELGATO_VER="1.19.0"

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@erinyoung
Copy link
Contributor

The tests looked like they worked

#12 0.726 [08/23/2024 01:22:17 PM | test/ ]  Finished running blastn/mompS
#12 0.726 [08/23/2024 01:22:17 PM | test/ ]  mompS alleles identified: 18
#12 0.726 [08/23/2024 01:22:17 PM | test/ ]  Running command: blastn -query GCF_900119765.1_2532STDY5467631_genomic.fna -db /usr/local/bin/db/all_loci.fasta -outfmt '6 std qlen slen' -max_target_seqs 50000
#12 0.726 [08/23/2024 01:22:17 PM | test/ ]  Running blast
#12 0.726 [08/23/2024 01:22:17 PM | test/ ]  Finished running blast
#12 0.726 [08/23/2024 01:22:17 PM | test/ ]  Command log for blast:
#12 0.726 qseqid         sseqid        pident   length  mismatch  gapopen  qstart   qend     sstart  send  evalue     bitscore  qlen     slen  
#12 0.726 NZ_LT632614.1  flaA_8        100.000  182     0         0        1498635  1498816  182     1     2.16e-90   337       3530817  182   
#12 0.726 NZ_LT632614.1  pilE_10       100.000  333     0         0        721006   721338   333     1     2.48e-174  616       3530817  333   
#12 0.726 NZ_LT632614.1  asd_3         100.000  473     0         0        2650534  2651006  473     1     0.0        874       3530817  473   
#12 0.726 NZ_LT632614.1  mip_15        100.000  402     0         0        941537   941938   1       402   0.0        743       3530817  402   
#12 0.726 NZ_LT632614.1  proA_1        100.000  405     0         0        568377   568781   1       405   0.0        749       3530817  405   
#12 0.726 NZ_LT632614.1  neuA_neuAH_6  100.000  354     0         0        898051   898404   1       354   0.0        654       3530817  354   
#12 0.726                
#12 0.726 
#12 0.726 [08/23/2024 01:22:17 PM | test/ ]  Finished running blast
#12 0.726 [08/23/2024 01:22:17 PM | test/ ]  Finished analysis
#12 0.726 [08/23/2024 01:22:17 PM | test/ ]  Output = 
#12 0.726 GCF_900119765.1_2532STDY5467631_genomic	62	8	10	3	15	18	1	6
#12 0.726 
#12 0.726 [08/23/2024 01:22:17 PM | test/ ]  The program took 0s
#12 DONE 0.8s

Copy link
Contributor

@erinyoung erinyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no changes to recommend.

I'm going to

  1. merge this PR
  2. deploy to dockerhub and quay for the 'elgato' image with tags '1.19.0' and 'latest'

@erinyoung erinyoung merged commit 88fb433 into StaPH-B:master Aug 28, 2024
2 checks passed
@erinyoung
Copy link
Contributor

Thank you for putting this together!

You can check the status of the deploy here : https://github.com/StaPH-B/docker-builds/actions/runs/10603682746

@Kincekara Kincekara deleted the elgato branch August 28, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants