Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding dnaapler version 0.8.0 #1036

Merged
merged 2 commits into from
Aug 22, 2024
Merged

adding dnaapler version 0.8.0 #1036

merged 2 commits into from
Aug 22, 2024

Conversation

erinyoung
Copy link
Contributor

There's a new version of dnaapler!

According to the release notes this update is mainly for archea, but will also allow it to finish if no hits are found (will give a warning).

I updated the software version arg to 0.8.0 and the base image to 1.5.8.

The full diff

$ diff dnaapler/0.7.0/Dockerfile dnaapler/0.8.0/Dockerfile 
1c1
< FROM mambaorg/micromamba:1.5.6 as app
---
> FROM mambaorg/micromamba:1.5.8 as app
7c7
< ARG DNAAPLER_VER="0.7.0"
---
> ARG DNAAPLER_VER="0.8.0"
10c10
< LABEL base.image="mambaorg/micromamba:1.4.1"
---
> LABEL base.image="mambaorg/micromamba:1.5.8"

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@Kincekara Kincekara merged commit d60d706 into master Aug 22, 2024
2 checks passed
@Kincekara
Copy link
Collaborator

Thank you for the update!
I added the "-f" flag to the "micromamba clean" command.
Deploy link: https://github.com/StaPH-B/docker-builds/actions/runs/10508547852

@erinyoung erinyoung deleted the erin-dnaapler branch September 25, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants