Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding clair3 version 1.0.10 #1035

Merged
merged 1 commit into from
Aug 22, 2024
Merged

adding clair3 version 1.0.10 #1035

merged 1 commit into from
Aug 22, 2024

Conversation

erinyoung
Copy link
Contributor

There's a new version of clair3!

According to the release notes, there is a bug fix, dependency update, and some performance improvements.

I update the software version ARG, added apt-get autoclean && rm -rf /var/lib/apt/lists/* to the app stage in the apt-get layer, replaced COPY with RUN wget for the test script (so it doesn't have to copied over and over).

Here is the full diff

$ diff clair3/1.0.*/Dockerfile
1c1
< ARG CLAIR3_VER="1.0.10"
---
> ARG CLAIR3_VER="1.0.9"
44c44
< RUN wget -q https://github.com/HKU-BAL/Clair3/archive/refs/tags/v${CLAIR3_VER}.tar.gz &&\
---
> RUN wget https://github.com/HKU-BAL/Clair3/archive/refs/tags/v${CLAIR3_VER}.tar.gz &&\
58c58
<     wget -q http://www.bio8.cs.hku.hk/clair3/clair3_models/clair3_models.tar.gz &&\    
---
>     wget http://www.bio8.cs.hku.hk/clair3/clair3_models/clair3_models.tar.gz &&\    
81,83c81
<     procps && \
<     apt-get autoclean && rm -rf /var/lib/apt/lists/*
< 
---
>     procps
116c114
< RUN run_clair3.sh
---
> RUN apt-get update && apt-get install -y wget
118c116
< RUN apt-get update && apt-get install -y wget 
---
> COPY ont_quick_test.sh . 
120,121c118
< RUN wget -q https://raw.githubusercontent.com/StaPH-B/docker-builds/master/clair3/1.0.9/ont_quick_test.sh && \
<     chmod +x ont_quick_test.sh &&\
---
> RUN chmod +x ont_quick_test.sh &&\

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@Kincekara Kincekara merged commit 4fdec45 into master Aug 22, 2024
2 checks passed
@Kincekara
Copy link
Collaborator

Thank you for the update!
Deploy link: https://github.com/StaPH-B/docker-builds/actions/runs/10508200165

@erinyoung erinyoung deleted the erin-clair branch September 25, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants