Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format #342

Closed
wants to merge 2 commits into from
Closed

format #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbe62fa
chore(format): use cache
xav-ie Sep 15, 2024
2b66e1b
refactor(lint:format): rename workflow
xav-ie Sep 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/prettier.yml → .github/workflows/lint-format.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
jobs:
prettier:
lint_format:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/prepare
- run: pnpm format --list-different
- run: pnpm lint:format

name: Prettier
name: Lint Format

on:
pull_request: ~
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@
"scripts": {
"build": "remix vite:build",
"dev": "remix vite:dev",
"format": "prettier --write .",
"format": "prettier --cache --write .",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you notice some performance issues without --cache?

"lint": "eslint . .*js --max-warnings 0",
"lint:format": "prettier --cache --check .",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I like to set up projects in general is lint:* scripts report you of violations and format:* scripts auto-fix said violations (as much as possible). I didn't set up this repo, but it seems to be done somewhat similarly. So here lint:format is a little contradicting to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Personally, I consider formatting to be a sibling to linting, not a sub-concern.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, that makes sense. I also did not notice significant speed increase, so I will close this.

"lint:knip": "knip",
"lint:md": "markdownlint \"**/*.md\" \".github/**/*.md\" --rules sentences-per-line",
"lint:packages": "pnpm dedupe --check",
Expand Down
Loading