🐛 Fix hash of binary files in cache service (attempt 2) #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPGoding
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
I'm still not exactly sure how the "too many files open" error occurred since from what I understand we're opening files in sequence, so there should never be multiple file handles open at the same time.
Edit: I somehow thought the this.dirtyFiles.size > 100 check was added in this PR to fix the error when it was in the original as well lol. Now I realize this PR is identical to the previous one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CacheService#1706But that PR created some issues where too many file handles were open (or something like that). I still think most of this PR are good changes, but might need some reworking