Add match regex attribute #1760
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeunEinser
approved these changes
Feb 16, 2025
There was a problem hiding this comment.
Lgtm, only thing is, I am not sure if the error message would actually work like this if we are thinking of translatable mcdoc. But I guess the attribute is not that relevant for vanilla-mcdoc anyways.
I do have some usecases for this attribute in my map, so I would love this feature :D
|
I think it's acceptible that the custom error message is not translatable |
misode
reviewed
Feb 17, 2025
SPGoding
reviewed
Feb 20, 2025
| const regex = RegExp(pattern) | ||
| if (!regex.test(value)) { | ||
| if (config.message) { | ||
| ctx.err.report(config.message, node, 2) |
There was a problem hiding this comment.
Suggested change
| ctx.err.report(config.message, node, 2) | |
| ctx.err.report(config.message, node, core.ErrorSeverity.Warning) |
You missed this :p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an attribute
match_regexthat allows for regex validation for string fields.Regex config is required but error is not. If error is not provided will use a default error message instead.
#[match_regex=(regex=foo, error="error")]