-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Integrate Spyglass web API #1746
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I experienced a corrupt vanilla-data cache once during unstable internet, but I can't really reproduce this.
I also experienced an error once that said versions.sort
is not a function (in resolveConfiguredVersion
), this would indicate that versions
was not underfined, but also not a list, which seems really strange. Writing this I realized this might've been an { "message": "..." }
, so maybe fetcher.ts
is not handling 4xx and 5xx responses correctly
api.spyglassmc.com
instead of from GitHub.Downloader
with something using theCache
API andfetch()
. Implemented a very simple shim of theCache
API inNodeJsExternals.ts
.Fixes #1734 and resolves #1480.