Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Integrate Spyglass web API #1746

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

✨ Integrate Spyglass web API #1746

wants to merge 14 commits into from

Conversation

SPGoding
Copy link
Member

@SPGoding SPGoding commented Feb 7, 2025

  • Changed to download resources from api.spyglassmc.com instead of from GitHub.
  • Replaced the old Downloader with something using the Cache API and fetch(). Implemented a very simple shim of the Cache API in NodeJsExternals.ts.

Fixes #1734 and resolves #1480.

@misode misode self-requested a review February 7, 2025 09:19
Copy link
Member

@misode misode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this branch locally, a lot (but not all) mcdoc symbols are borked.
image

Looking at the warning paths, maybe the stripLevel is incorrect now?

@misode misode self-requested a review February 17, 2025 00:56
Copy link
Member

@misode misode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I experienced a corrupt vanilla-data cache once during unstable internet, but I can't really reproduce this.

I also experienced an error once that said versions.sort is not a function (in resolveConfiguredVersion), this would indicate that versions was not underfined, but also not a list, which seems really strange. Writing this I realized this might've been an { "message": "..." }, so maybe fetcher.ts is not handling 4xx and 5xx responses correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants