pynipap as a package #1412
Merged
pynipap as a package #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 9, 2025
garberg
force-pushed
the
pynipap_as_a_package
branch
2 times, most recently
from
9da23a5 to
1bb18e0
Compare
houndci-bot
reviewed
Jan 9, 2025
garberg
force-pushed
the
pynipap_as_a_package
branch
from
1bb18e0 to
ba69389
Compare
houndci-bot
reviewed
Jan 9, 2025
garberg
force-pushed
the
pynipap_as_a_package
branch
from
ba69389 to
3525bf9
Compare
Mainly to avoid cluttering the global namespace with the name "tracing", moved the pynipap module to its own package. The intention is that the package should be fully compatible with the stans-alone module and require no changes to the applications using it.
Despite my intentions to keep the API unchanged, a small change was needed to the CLI client to cater for pynipap as a package.
garberg
force-pushed
the
pynipap_as_a_package
branch
from
3525bf9 to
0e5d6da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to avoid cluttering the global namespace with the name "tracing", moved the pynipap module to its own package.
The intention is that the package should be fully compatible with the stand-alone module and require no changes to the applications using it.