[Repairibility]: fixed false positives of NPEfix on repogit4test data #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cannot reproduce the failure locally, so we have to fix #115 first and then restart the build here to understand the problem. |
|
I am replacing prints with log but I don't know where to look in the Travis output to see if the problem is fixed, I don't find a max Travis limit error in the CI's output. @monperrus @martinezmatias |
|
CI is broken because of continuous deployment. Fixed it in c04b486. |
|
We're making progress, at least one build passes https://travis-ci.org/SpoonLabs/coming/builds/560932472 Merging to move forward |
|
what you merged has the changed for NPEfix and also log. Is that fine? I was trying to go back in the commits and create a separate PR for logs. @monperrus |
|
what you merged has the changed for NPEfix and also log. Is that fine?
not optimal, but still OK :-) it's important to keep momentum by merging good-enough pull requests.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.