Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tests silent (the tests log are longer than the maximum Travis size) #115

Open
monperrus opened this issue Jul 18, 2019 · 5 comments
Open

Comments

@monperrus
Copy link
Contributor

The tests of Coming are too verbose, and the console logs reach the Travis limit.

Consequently, it is impossible to debug the Travis failure, eg https://travis-ci.org/SpoonLabs/coming/builds/559463057

We must make the tests silent.

@martinezmatias
Copy link
Collaborator

Hi Martin
Yes, agree, the log level by default now is DEBUG: https://github.com/SpoonLabs/coming/blob/master/src/main/resources/log4j.properties#L3

@monperrus
Copy link
Contributor Author

The console outputs come from System.out.println in both application code src/main/java and test code src/test/java.

The first thing to do is to replace the most common System.out.println (those polluting the output) by proper log4j log statements.

@niloofartrg works on this

@martinezmatias
Copy link
Collaborator

Perfect

@niloofartrg
Copy link
Collaborator

Is this issue still in progress or the logs added were sufficient? @monperrus

@monperrus
Copy link
Contributor Author

No, there is still some work to do. We must remove all the "analyzing", "etc".

We want that the maximum log lines stays below 10000 lines to be browsed on the Travis interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants