Upgrade cef_binary to 129.0.11+g57354b8+chromium-129.0.6668.90

SpiralP · Oct 6, 2024 · 8227645 · 8227645
1 parent 865f247
commit 8227645
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -28,10 +28,10 @@ jobs:
         config:
           - arch: x86_64
             target: x86_64-pc-windows-msvc
-            url: https://cef-builds.spotifycdn.com/cef_binary_128.4.12%2Bg1d7a1f9%2Bchromium-128.0.6613.138_windows64.tar.bz2
+            url: https://cef-builds.spotifycdn.com/cef_binary_129.0.11%2Bg57354b8%2Bchromium-129.0.6668.90_windows64.tar.bz2
           - arch: i686
             target: i686-pc-windows-msvc
-            url: https://cef-builds.spotifycdn.com/cef_binary_128.4.12%2Bg1d7a1f9%2Bchromium-128.0.6613.138_windows32.tar.bz2
+            url: https://cef-builds.spotifycdn.com/cef_binary_129.0.11%2Bg57354b8%2Bchromium-129.0.6668.90_windows32.tar.bz2
 
     steps:
       - uses: actions/checkout@v4
@@ -130,7 +130,7 @@ jobs:
         config:
           - arch: x86_64
             target: x86_64-unknown-linux-gnu
-            url: https://cef-builds.spotifycdn.com/cef_binary_128.4.12%2Bg1d7a1f9%2Bchromium-128.0.6613.138_linux64.tar.bz2
+            url: https://cef-builds.spotifycdn.com/cef_binary_129.0.11%2Bg57354b8%2Bchromium-129.0.6668.90_linux64.tar.bz2
           - arch: i686
             target: i686-unknown-linux-gnu
             # Linux x86 32-bit builds are discontinued after version 101 (details)
@@ -218,10 +218,10 @@ jobs:
         config:
           - arch: armhf
             target: armv7-unknown-linux-gnueabihf
-            url: https://cef-builds.spotifycdn.com/cef_binary_128.4.12%2Bg1d7a1f9%2Bchromium-128.0.6613.138_linuxarm.tar.bz2
+            url: https://cef-builds.spotifycdn.com/cef_binary_129.0.11%2Bg57354b8%2Bchromium-129.0.6668.90_linuxarm.tar.bz2
           - arch: aarch64
             target: aarch64-unknown-linux-gnu
-            url: https://cef-builds.spotifycdn.com/cef_binary_128.4.12%2Bg1d7a1f9%2Bchromium-128.0.6613.138_linuxarm64.tar.bz2
+            url: https://cef-builds.spotifycdn.com/cef_binary_129.0.11%2Bg57354b8%2Bchromium-129.0.6668.90_linuxarm64.tar.bz2
 
     steps:
       - uses: actions/checkout@v4
@@ -299,7 +299,7 @@ jobs:
         config:
           - arch: x86_64
             target: x86_64-apple-darwin
-            url: https://cef-builds.spotifycdn.com/cef_binary_128.4.12%2Bg1d7a1f9%2Bchromium-128.0.6613.138_macosx64.tar.bz2
+            url: https://cef-builds.spotifycdn.com/cef_binary_129.0.11%2Bg57354b8%2Bchromium-129.0.6668.90_macosx64.tar.bz2
 
     steps:
       - uses: actions/checkout@v4

diff --git a/flake.nix b/flake.nix
@@ -27,7 +27,7 @@
                 # "aarch64-darwin" = { platformUrl = "macosarm64"; projectArchCmake = "arm64"; };
               };
 
-              platforms."x86_64-linux".hash = "sha256-Q8PFWpc7C68H/TPp4QsDSRV2EIdpmqq0XNGRo4P053Q=";
+              platforms."x86_64-linux".hash = "sha256-0NAbXioAYwPUqc/mOqyq9dA0Vt2rGfytCQ125D5/aho=";
               # platforms."aarch64-linux".hash = "";
               # platforms."armv7l-linux".hash = "";
               # platforms."x86_64-darwin".hash = "";
@@ -36,23 +36,22 @@
               inherit (platforms.${pkgs.stdenv.hostPlatform.system}) platformUrl projectArchCmake hash;
             in
             (prev: rec {
-              version = "128.4.12+g1d7a1f9+chromium-128.0.6613.138";
+              version = "129.0.11+g57354b8+chromium-129.0.6668.90";
 
               src = pkgs.fetchzip {
                 inherit hash;
                 name = "cef_binary-${version}";
                 url = "https://cef-builds.spotifycdn.com/cef_binary_${version}_${platformUrl}.tar.bz2";
               };
 
-              installPhase = ''
-                ${prev.installPhase}
-
+              installPhase = prev.installPhase + ''
                 # cef wants icu file next to the .so
                 mv -v $out/share/cef/* $out/lib/
                 rmdir $out/share/cef $out/share
 
-                # needed to fix "FATAL:udev_loader.cc(48)] Check failed: false."
-                patchelf --add-rpath "${lib.makeLibraryPath [pkgs.libudev0-shim]}" $out/lib/*.so
+                # old: needed to fix "FATAL:udev_loader.cc(48)] Check failed: false."
+                # needs libudev.so.1 now instead of previous ^ so.0 to link at compile time
+                patchelf --add-rpath "${lib.makeLibraryPath [ pkgs.udev ]}" $out/lib/*.so
               '';
 
               cmakeFlags =