Bump base etc.
#65
Bump base etc.
#65
Conversation
``` * What went wrong: Execution failed for task ':proto:configuration:test'. > No tests found for given includes: [*Spec, *Test](filter.includeTestsMatching) ```
Also: * Remove extra version constants.
alexander-yevsyukov
requested review from
armiol,
yevhenii-nadtochii and
dmdashenkov
and removed request for
armiol and
yevhenii-nadtochii
|
Pardon, does not see Kotlin DSL at CI again. |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jetbrains.dokka</groupId> | ||
| <artifactId>javadoc-plugin</artifactId> | ||
| <version>1.7.10</version> | ||
| <version>1.7.20</version> |
There was a problem hiding this comment.
High Vulnerability:
maven : org.jetbrains.dokka/javadoc-plugin : 1.7.20
0 Critical, 2 High, 2 Medium, 0 Low vulnerabilities have been found across 3 dependencies.
View the Lift console for details about these vulnerabilities.
There are 109 breaking API changes if you upgrade to the latest version (1.7.20).
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -164,7 +164,7 @@ all modules and does not describe the project structure per-subproject. | |||
| <dependency> | |||
| <groupId>com.google.errorprone</groupId> | |||
| <artifactId>error_prone_core</artifactId> | |||
| <version>2.13.1</version> | |||
| <version>2.16</version> | |||
There was a problem hiding this comment.
Medium Vulnerability:
maven : com.google.errorprone/error_prone_core : 2.16
0 Critical, 0 High, 1 Medium, 0 Low vulnerabilities have been found across 1 dependencies.
View the Lift console for details about these vulnerabilities.
There are 279 breaking API changes if you upgrade to the latest version (2.16).
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
============================================
- Coverage 43.85% 43.66% -0.19%
+ Complexity 451 447 -4
============================================
Files 122 122
Lines 2654 2654
Branches 212 212
============================================
- Hits 1164 1159 -5
- Misses 1444 1446 +2
- Partials 46 49 +3 |
|
@armiol, @dmdashenkov, I had to rollback usage of Kotlin proto-DSL because it breaks compilation at CI (and locally, if you make a pause between This time it doesn't find DSL code which is part of ProtoData Anyway, PTAL. |
|
@alexander-yevsyukov this whole story with DSL is weird to me. Not much changed in our codebase, and yet such a thing was never observed on CI previously. Can it be caused by some unfinished business in the Gradle nightly build that we started using everywhere recently? Just out of curiosity, let's also try the latest nightly build (see https://gradle.org/release-nightly/). |
|
@alexander-yevsyukov OK, I see that you are using the latest nightly build already. Maybe, that's what breaks stuff? Let's try rolling back to the previously used nightly build (the one we started to use first). Also, if we have any Gradle cache enabled at CI, let's disable it in the scope of GH Actions pipeline. |
I switched to this version in the hope that it's fixed by the latest Gradle code. I can switch back, but I've already tried many different nightbuilds of Gradle when trying to solve this issue in ProtoData. It didn't work. I guess I need to have a closer look at how we filter |
This PR:
baseand other dependencies on Spine modules and those fromconfig.TypeSystemSpectest suite.There are some
MakeTestFilterHappyTest.javafiles in this change set. They are needed because of this issue.