Remove dependency on Validation runtime #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-yevsyukov
changed the title
api level
alexander-yevsyukov
changed the title
api levelAlso: * Optimise imports.
armiol
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes validation constraints previously added to Protobuf types in the
tool-basemodule. Sincetool-baseuses vanilla Protobuf codegen (and not McJava), validation options have no effect, and are simply misleading.Also the PR removes the redundant
implementationdependency oftool-baseonspine-validation-java-runtime.The dependency caused version confusion in sub-projects that depend on
tool-base.The dependency on
spine-baseis still relevant for having the(type_url_prefix)file option, which is used by Spine utilities for working for packing messages into ProtobufAny.configwas also updated.