Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Jacoco version explicitly #83

Merged
merged 20 commits into from
May 6, 2024
Merged

Set Jacoco version explicitly #83

merged 20 commits into from
May 6, 2024

Conversation

armiol
Copy link
Contributor

@armiol armiol commented Nov 26, 2023

This PR improves the configuration of Jacoco ensuring the version is explicitly set from the one declared in the dependency object.

@armiol armiol self-assigned this Nov 26, 2023
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.11%. Comparing base (2eb292c) to head (fcd48fb).
Report is 37 commits behind head on master.

❗ Current head fcd48fb differs from pull request most recent head e80cf37. Consider uploading reports for the commit e80cf37 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #83   +/-   ##
=========================================
  Coverage     63.11%   63.11%           
  Complexity      843      843           
=========================================
  Files           117      117           
  Lines          3863     3863           
  Branches        529      529           
=========================================
  Hits           2438     2438           
  Misses         1213     1213           
  Partials        212      212           

@armiol armiol marked this pull request as ready for review November 26, 2023 13:49
@armiol
Copy link
Contributor Author

armiol commented Nov 26, 2023

@alexander-yevsyukov PTAL.

Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…-2023

# Conflicts:
#	buildSrc/build.gradle.kts
#	buildSrc/src/main/kotlin/DependencyResolution.kt
#	buildSrc/src/main/kotlin/io/spine/internal/dependency/Kotlin.kt
#	buildSrc/src/main/kotlin/io/spine/internal/dependency/ProtoData.kt
#	buildSrc/src/main/kotlin/io/spine/internal/dependency/Protobuf.kt
#	buildSrc/src/main/kotlin/io/spine/internal/dependency/Spine.kt
#	buildSrc/src/main/kotlin/io/spine/internal/dependency/Validation.kt
#	buildSrc/src/main/kotlin/io/spine/internal/gradle/report/coverage/JacocoConfig.kt
#	buildSrc/src/main/kotlin/jvm-module.gradle.kts
#	dependencies.md
#	pom.xml
#	tests/jvm-slf4j-jdk14-backend-std-context/build.gradle.kts
#	tests/jvm-slf4j-reload4j-backend-std-context/build.gradle.kts
@alexander-yevsyukov alexander-yevsyukov changed the title Update dependencies and rename license-report.md to dependencies.md Set Jacoco version explicitly May 6, 2024
@alexander-yevsyukov
Copy link
Contributor

@armiol, I cannot add you as a reviewer because you were the original author of the PR.

PTAL.

@armiol armiol merged commit 1940a83 into master May 6, 2024
6 checks passed
@armiol armiol deleted the update-config-26-11-2023 branch May 6, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants