-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the latest config
#175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
=========================================
Coverage 87.44% 87.44%
Complexity 462 462
=========================================
Files 74 74
Lines 1729 1729
Branches 81 81
=========================================
Hits 1512 1512
Misses 188 188
Partials 29 29 |
@armiol Please take a look. |
armiol
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the repository to use the latest
config
.Mostly, this is done in order to pull in the following changes:
Applying of those changes led to the following:
testJar
artifact has disappeared from the list of artifacts published by the modules. This artifact is optional now and not published by default.protoJar
artifact has also disappeared in modules that don't have any proto definitions.Please note, the repository does not use the latest version of ErrorProne and some Spine libraries. In particular
mc-java
. Take a look on #176 for details.The library version is bumped to
2.0.0-SNAPSHOT.67
.