Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate Error thrown by a receptor #1560

Merged
merged 9 commits into from
Dec 13, 2024
Merged

Conversation

alexander-yevsyukov
Copy link
Contributor

This PR updates the AbstractReceiver class to make it throw java.lang.Error if it was thrown by a receptor method. Such an ability is needed when we want to terminate the execution instead of storing the error in DispatchOutcome.

One of the use cases is Validation library which wants to terminate the compilation for illegal usage of a validation option.

Other notable changes

  • config was updated.
  • Recent deprecations from Base were addressed.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Dec 13, 2024
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review December 13, 2024 19:02
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.76%. Comparing base (a3ce28e) to head (e12d77e).
Report is 10 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1560      +/-   ##
============================================
+ Coverage     89.75%   89.76%   +0.01%     
- Complexity     5020     5022       +2     
============================================
  Files           646      646              
  Lines         15758    15759       +1     
  Branches        920      921       +1     
============================================
+ Hits          14143    14146       +3     
+ Misses         1281     1280       -1     
+ Partials        334      333       -1     

@alexander-yevsyukov alexander-yevsyukov merged commit 2692136 into master Dec 13, 2024
7 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the propagate-error branch December 13, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants