Inline functions for routing #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * Introduce inline fun with generics. * Add `unableToRoute()` function. * Address console warnings on receptors. * Bump McJava -> `2.0.0-SNAPSHOT.171`.
Also: * Add extension inline fun for routing.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1539 +/- ##
============================================
+ Coverage 89.78% 89.79% +0.01%
+ Complexity 4998 4994 -4
============================================
Files 648 648
Lines 15692 15690 -2
Branches 906 906
============================================
Hits 14089 14089
+ Misses 1286 1285 -1
+ Partials 317 316 -1 |
armiol
requested changes
Oct 13, 2023
server/src/main/java/io/spine/server/entity/EventDispatchingRepository.java
Show resolved
Hide resolved
armiol
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
@alexander-yevsyukov LGTM.
As discussed, Kotlin Set<I> means Set<? extends I> in Java, since it has a built-in covariance for the generic type. In routing, we expect exactly I-typed IDs. So the explicit cast is better in terms of semantics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts
CommandRoutingandEventRoutingto Kotlin, extending these classes with inline functions for idiomatic routing configuration in Kotlin.Other notable changes: