More internal type filtering #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * Unify handling of internal types in the abstract base.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1471 +/- ##
=========================================
Coverage 91.39% 91.40%
+ Complexity 5012 5006 -6
=========================================
Files 631 632 +1
Lines 15402 15424 +22
Branches 887 882 -5
=========================================
+ Hits 14077 14098 +21
Misses 1019 1019
- Partials 306 307 +1 |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
alexander-yevsyukov
requested review from
armiol,
a team and
yevhenii-nadtochii
|
@yevhenii-nadtochii, since you were the author of (#1449), you may want to have a look at this PR. |
There was a problem hiding this comment.
@alexander-yevsyukov thank you. I've checked this out and left several suggestions. LGTM, but I would preserve the power of a formal approve to other reviewers.
armiol
requested changes
Sep 19, 2022
There was a problem hiding this comment.
@alexander-yevsyukov please see the comments left by @yevhenii-nadtochii
Other than those, LGTM.
armiol
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR teaches
QueryServiceandSubscriptionServiceto reject calls referring types marked asinternal_type(either directly in a type option or via a file optioninternal_all).To extract common logic of processing, an abstract
ServiceDelegateclass was introduced.CommandService,QueryService, andSubscriptionServicewere modified to processing calls to classes derived fromServiceDelegate.Also
UnknownEntityTypeExceptionwas renamed toUnknownEntityStateTypeExceptionto better reflect the cause of the error.