Skip to content

Shorter plugin ID, rejections for custom source sets #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 77 commits into
base: master
Choose a base branch
from

Conversation

alexander-yevsyukov
Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov commented Dec 7, 2021

This PR:

  • Changes the ID of the bootstrap plugin to io.spine.bootstrap. Previously, it was annoyingly longer (io.spine.tools.gradle.bootstrap).
  • Enables generation of Rejections to source sets other than main or test.
  • Removes configuration of IdeaModel in Gradle in relation to Spine. Such configuration actions are either already performed by corresponding plugins (e.g. inclusion of directories into source sets), or should not be done at the level of the bootstrap plugin because it's too intrusive (e.g. setting downloading of Javadoc or source code).
  • Updates dependencies on base, tool-base, mc- plugins, and config.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Dec 7, 2021
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review December 17, 2021 00:30
@alexander-yevsyukov alexander-yevsyukov marked this pull request as draft December 17, 2021 00:30
<artifactId>checkstyle</artifactId>
<version>9.1</version>
</dependency>
<dependency>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical OSS Vulnerability:

pkg:maven/net.sourceforge.pmd/[email protected]

1 Critical, 1 Severe, 0 Moderate, 0 Unknown vulnerabilities have been found across 2 dependencies

Components
    pkg:maven/com.google.code.gson/[email protected]
      CRITICAL Vulnerabilities (1)

        [sonatype-2021-1694] CWE-502: Deserialization of Untrusted Data

        gson - Deserialization of Untrusted Data

        The application deserializes untrusted data without sufficiently verifying that the resulting data will be valid.

        CVSS Score: 7.5

        CVSS Vector: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H

        CWE: CWE-502

    pkg:maven/commons-io/[email protected]
      SEVERE Vulnerabilities (1)

        [sonatype-2018-0705] CWE-22: Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal')

        commons-io - Path Traversal [CVE-2021-29425]

        The software uses external input to construct a pathname that is intended to identify a file or directory that is located underneath a restricted parent directory, but the software does not properly neutralize special elements within the pathname that can cause the pathname to resolve to a location that is outside of the restricted directory.

        CVSS Score: 5.3

        CVSS Vector: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:N/A:N

        CWE: CWE-22

(at-me in a reply with help or ignore)


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@@ -28,109 +26,127 @@ all modules and does not describe the project structure per-subproject.
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>30.0-jre</version>
<version>30.1.1-jre</version>
<scope>compile</scope>
</dependency>
<dependency>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severe OSS Vulnerability:

pkg:maven/com.google.protobuf/[email protected]

0 Critical, 1 Severe, 0 Moderate, 0 Unknown vulnerabilities have been found across 1 dependencies

Components
    pkg:maven/com.google.guava/[email protected]
      SEVERE Vulnerabilities (1)

        [sonatype-2020-0926] CWE-379: Creation of Temporary File in Directory with Incorrect Permissions

        guava - Creation of Temporary File in Directory with Insecure Permissions [CVE-2020-8908]

        The software creates a temporary file in a directory whose permissions allow unintended actors to determine the file's existence or otherwise access that file.

        CVSS Score: 6.2

        CVSS Vector: CVSS:3.1/AV:L/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N

        CWE: CWE-379

(at-me in a reply with help or ignore)


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant