Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark (default_message) as internal #845

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

yevhenii-nadtochii
Copy link
Contributor

@yevhenii-nadtochii yevhenii-nadtochii commented Dec 18, 2024

This PR marks (default_message) option as internal and updates its docs.

@yevhenii-nadtochii yevhenii-nadtochii self-assigned this Dec 18, 2024
@yevhenii-nadtochii yevhenii-nadtochii marked this pull request as ready for review December 18, 2024 16:31
@yevhenii-nadtochii
Copy link
Contributor Author

@armiol @alexander-yevsyukov PTAL

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.15%. Comparing base (d3b2d00) to head (715316e).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #845   +/-   ##
=========================================
  Coverage     75.15%   75.15%           
  Complexity     1180     1180           
=========================================
  Files           191      191           
  Lines          4298     4298           
  Branches        346      346           
=========================================
  Hits           3230     3230           
  Misses          937      937           
  Partials        131      131           

@yevhenii-nadtochii yevhenii-nadtochii merged commit 89e016b into master Dec 18, 2024
7 checks passed
@yevhenii-nadtochii yevhenii-nadtochii deleted the undeprecate-default-message branch December 18, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants