Migrate to JDK 11 and Java 11 syntax [part 1] #698
Conversation
…ypeCanBeExplicit`.
armiol
changed the title
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
============================================
- Coverage 78.78% 78.67% -0.11%
+ Complexity 1756 1753 -3
============================================
Files 247 247
Lines 5868 5777 -91
Branches 433 433
============================================
- Hits 4623 4545 -78
+ Misses 1072 1058 -14
- Partials 173 174 +1 |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
|
|
||
| workingDir(this@npm) | ||
| commandLine(npmExecutable) | ||
| args(*args) |
There was a problem hiding this comment.
SpreadOperator: In most cases using a spread operator causes a full copy of the array to be created before calling a method which has a very high performance penalty.
(at-me in a reply with help or ignore)
There was a problem hiding this comment.
@sonatype-lift ignore
There was a problem hiding this comment.
I've recorded this as ignored for this pull request. If you change your mind, just comment @sonatype-lift unignore.
| PackageInfo newNode = PackageInfo.of(current); | ||
| final var current = first; | ||
| var directParent = graph.nodes().stream() | ||
| .filter((node) -> IsDirectParent.of(current) |
There was a problem hiding this comment.
Please extract IsDirectParent.of(current) from the lambda. Also, there is something strange going on with the renaming first to current. Maybe, we could get rid of that as well.
| var unslashed = matcher.find() ? | ||
| matcher.replaceAll(BACKSLASH + matcher.group()) : | ||
| stringToQuote; |
There was a problem hiding this comment.
Don't we usually put the ? and the : on the following lines?
I remember that because it does not work in Groovy, we had to use the other format (the one used in this snippet).
This changeset is the first part of the migration to Java 11.
vars instead of explicit types — this is done for the part of the source files;In scope of this changeset, a lot of "unused" endpoints were discovered. See #699 on this matter.
The library version is set to
2.0.0-SNAPSHOT.78.