Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Compilation.Error extend Mistake #306

Merged
merged 10 commits into from
Dec 15, 2024

Conversation

alexander-yevsyukov
Copy link
Collaborator

@alexander-yevsyukov alexander-yevsyukov commented Dec 15, 2024

This PR makes the Compilation.Error extension extend io.spine.base.Mistake type instead of java.lang.Error so that the error can be better propagated when raised by message handling classes.

Also, the Compilation.error() function now always prints the error message to System.err. Previously, it was printed only in the production mode. The change allows tests to verify the console output much easier.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Dec 15, 2024
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review December 15, 2024 17:41
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.32%. Comparing base (2fdf8a6) to head (a1e6414).
Report is 11 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #306      +/-   ##
============================================
+ Coverage     76.29%   76.32%   +0.02%     
  Complexity      533      533              
============================================
  Files           179      179              
  Lines          4071     4071              
  Branches        382      382              
============================================
+ Hits           3106     3107       +1     
+ Misses          839      838       -1     
  Partials        126      126              

@alexander-yevsyukov alexander-yevsyukov merged commit 40bd825 into master Dec 15, 2024
8 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the compilation-error-as-error branch December 15, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants