Rabbitmq connection setup expose channel rpc timeout #192
+13
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 21, 2020 11:29
livius-ungureanu
force-pushed
the
rabbitmq-connection-setup-expose-channelRpcTimeout
branch
from
cab5bcc to
cc12f09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The AMQP drivers executes an AMQP command within a certain amount of time (i.e. ConnectionFactory.DEFAULT_CHANNEL_RPC_TIMEOUT). Op-rabbit should allow the op-rabbit user to set this timeout according to his needs. In order to achieve this
com.spingo.op_rabbit.ConnectionParamsshould expose it in the last parameter of the constructor:channelRpcTimeout: Int = ConnectionFactory.DEFAULT_CHANNEL_RPC_TIMEOUTThis also ensures backward compatibility.
@timcharper this is branched off rabbitmq-connection-setup-callback which is waiting for merge approval into master.