First pass of deprecation removals for 0.103.0 #3993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What I haven't changed 1) our the waveform extractor combability. It was listened as maybe remove for 0.103.0 but I say keep--maybe to discuss at a maintenance meeting |
|
I would like to suggest as we update deprecations (myself included) that we try to add a comment in the tests as well with the deprecation version to make it easier to find. I tried searching based on deprecation term, but missed a few in testing as we can see from the failed testing. I think the extra effort will speed this along moving forward :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just did a search of the code base for all our dep warnings for removals in 0.103.0 and removed, updated some docs related to the deps and fixed tests that I could find. I probably missed something so I'll keep it on draft for the moment.