Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null Exception when trying to hide disposed container GUI with Project Auga #13

Open
Augure34 opened this issue Oct 18, 2023 · 4 comments
Labels
bug Something isn't working compatibility Other mods might be involved

Comments

@Augure34
Copy link

Augure34 commented Oct 18, 2023

Describe the bug
After interacting with a container and trying to close, a Null exception is thrown. The container GUI is not displayed but the crafting GUI stays displayed and can't be exited (therefor you can't open the menu or anything and need to restart)

To Reproduce
Open container and close with ESC having Project Auga installed alongside

Expected behaviour
Should be able to close the crafting GUI

LogOutput file(s)
Player.log
[Debug :XStorage.Log] [PanelManager.Hide] Hiding
NullReferenceException: Object reference not set to an instance of an object

Version
1.1.6 (latest)

Environment
Choose from the following options where you are experiencing the problem (leave only the ones you know about):

  • Singleplayer

Other mods
Project Auga compatibility is certainly at fault here, but here is the complete anyway:

{
"relPath": "FloorsAreRoofs.dll",
"source": "FloorsAreRoofs-1039-2-0-2-1695685882",
"target": "",
"time": 1695652526000
},
{
"relPath": "skyheim.dll",
"source": "Skyheim-916-1-3-4-1692837982",
"target": "",
"time": 1692837838000
},
{
"relPath": "ValheimRAFT\ValheimRAFT.dll",
"source": "ValheimRAFT 1.4.9-1136-1-4-9-1692901079",
"target": "",
"time": 1692900745000
},
{
"relPath": "ValheimRAFT\ValheimRAFT.dll.mdb",
"source": "ValheimRAFT 1.4.9-1136-1-4-9-1692901079",
"target": "",
"time": 1686836052000
},
{
"relPath": "ValheimRAFT\ValheimRAFT.pdb",
"source": "ValheimRAFT 1.4.9-1136-1-4-9-1692901079",
"target": "",
"time": 1692900745000
},
{
"relPath": "ValheimRAFT\Assets\Logos\pirate_skull.png",
"source": "ValheimRAFT 1.4.9-1136-1-4-9-1692901079",
"target": "",
"time": 1657517731000
},
{
"relPath": "ValheimRAFT\Assets\Patterns\checker.png",
"source": "ValheimRAFT 1.4.9-1136-1-4-9-1692901079",
"target": "",
"time": 1657491379000
},
{
"relPath": "ValheimRAFT\Assets\Patterns\dot.png",
"source": "ValheimRAFT 1.4.9-1136-1-4-9-1692901079",
"target": "",
"time": 1657491435000
},
{
"relPath": "ValheimRAFT\Assets\Patterns\stripe.png",
"source": "ValheimRAFT 1.4.9-1136-1-4-9-1692901079",
"target": "",
"time": 1657491298000
},
{
"relPath": "ValheimRAFT\Assets\Patterns\dot2.png",
"source": "ValheimRAFT 1.4.9-1136-1-4-9-1692901079",
"target": "",
"time": 1657493457000
},
{
"relPath": "ValheimRAFT\Assets\Sails\sail.png",
"source": "ValheimRAFT 1.4.9-1136-1-4-9-1692901079",
"target": "",
"time": 1617600224000
},
{
"relPath": "ValheimRAFT\Assets\Sails\sail_normal.png",
"source": "ValheimRAFT 1.4.9-1136-1-4-9-1692901079",
"target": "",
"time": 1617600222000
},
{
"relPath": "ValheimRAFT\Assets\Translations\English\valheimraft.json",
"source": "ValheimRAFT 1.4.9-1136-1-4-9-1692901079",
"target": "",
"time": 1661926001000
},
{
"relPath": "Valheim.SpawnThat.dll",
"source": "SpawnThat-453-1-2-7-1693849237",
"target": "",
"time": 1693848674000
},
{
"relPath": "YamlDotNet.dll",
"source": "SpawnThat-453-1-2-7-1693849237",
"target": "",
"time": 1624916158000
},
{
"relPath": "EquipmentAndQuickSlots.dll",
"source": "Equipment and Quick Slots-92-2-1-7-1692719465",
"target": "",
"time": 1696754085000
},
{
"relPath": "YamlDotNet.LICENSE.txt",
"source": "SpawnThat-453-1-2-7-1693849237",
"target": "",
"time": 1682713020000
},
{
"relPath": "Jotunn\CHANGELOG.md",
"source": "Jotunn-1138-2-14-2-1696356698",
"target": "",
"time": 1696776478000
},
{
"relPath": "Jotunn\Jotunn.dll",
"source": "Jotunn-1138-2-14-2-1696356698",
"target": "",
"time": 1696779006000
},
{
"relPath": "Jotunn\Jotunn.dll.mdb",
"source": "Jotunn-1138-2-14-2-1696356698",
"target": "",
"time": 1696779008000
},
{
"relPath": "Jotunn\Jotunn.pdb",
"source": "Jotunn-1138-2-14-2-1696356698",
"target": "",
"time": 1696779006000
},
{
"relPath": "Jotunn\README.md",
"source": "Jotunn-1138-2-14-2-1696356698",
"target": "",
"time": 1695073762000
},
{
"relPath": "Jotunn\Jotunn.xml",
"source": "Jotunn-1138-2-14-2-1696356698",
"target": "",
"time": 1696779006000
},
{
"relPath": "BoneAppetit.dll",
"source": "BoneAppetit-1250-3-3-1694456569(1)",
"target": "",
"time": 1694456445000
},
{
"relPath": "OhhLoz-HoneyPlus\HoneyPlus.dll",
"source": "HoneyPlus-2063-5-3-0-1694060163",
"target": "",
"time": 1694059743000
},
{
"relPath": "OhhLoz-HoneyPlus\icon.png",
"source": "HoneyPlus-2063-5-3-0-1694060163",
"target": "",
"time": 1617204242000
},
{
"relPath": "OhhLoz-HoneyPlus\manifest.json",
"source": "HoneyPlus-2063-5-3-0-1694060163",
"target": "",
"time": 1694059729000
},
{
"relPath": "AutomaticFuel.dll",
"source": "AutomaticFuel-2039-1-3-8-1692746028",
"target": "",
"time": 1696533626000
},
{
"relPath": "OhhLoz-HoneyPlus\README.md",
"source": "HoneyPlus-2063-5-3-0-1694060163",
"target": "",
"time": 1694059697000
},
{
"relPath": "Jewelcrafting.dll",
"source": "Smoothbrain-Jewelcrafting-1.5.1",
"target": "",
"time": 1697219078000
},
{
"relPath": "Soulcatcher_KG_JC_Additions.dll",
"source": "KGvalheim-Soulcatcher_JC_KG_Additions-4.5.3",
"target": "",
"time": 1696893254000
},
{
"relPath": "UsefulArmorStands.dll",
"source": "UsefulArmorStands-2214-1-0-4-1674231230",
"target": "",
"time": 1674202338000
},
{
"relPath": "Advize_PlantEasily.dll",
"source": "Plant Easily-2350-1-6-0-1692738466",
"target": "",
"time": 1696470640000
},
{
"relPath": "WeaponAdditions.dll",
"source": "WeaponAdditions-2536-1-0-0-1695408269",
"target": "",
"time": 1697278982000
},
{
"relPath": "WeaponAdditions.English.yml",
"source": "WeaponAdditions-2536-1-0-0-1695408269",
"target": "",
"time": 1697218761000
},
{
"relPath": "RRRCore.dll",
"source": "neurodr0me-RRRCore-3.1.4",
"target": "",
"time": 1696931722000
},
{
"relPath": "CONFIG GUIDES\ConfigGuide.md",
"source": "neurodr0me-RRRCore-3.1.4",
"target": "",
"time": 1619783722000
},
{
"relPath": "CONFIG GUIDES\ConfigGuide_AttackNames.txt",
"source": "neurodr0me-RRRCore-3.1.4",
"target": "",
"time": 1619783756000
},
{
"relPath": "CONFIG GUIDES\ConfigGuide_AdvancedCustomAttacks.txt",
"source": "neurodr0me-RRRCore-3.1.4",
"target": "",
"time": 1621612506000
},
{
"relPath": "CONFIG GUIDES\ConfigGuide_MonsterAnims.txt",
"source": "neurodr0me-RRRCore-3.1.4",
"target": "",
"time": 1619782940000
},
{
"relPath": "CONFIG GUIDES\ConfigGuide_CustomTexture.txt",
"source": "neurodr0me-RRRCore-3.1.4",
"target": "",
"time": 1621612824000
},
{
"relPath": "CONFIG GUIDES\ConfigGuide_PlayerAttackAnims.txt",
"source": "neurodr0me-RRRCore-3.1.4",
"target": "",
"time": 1619782854000
},
{
"relPath": "SeedTotem\seed-totem-auto-field-custom-requirements.json",
"source": "SeedTotem-876-4-3-3-1697235558",
"target": "",
"time": 1634942330000
},
{
"relPath": "CONFIG GUIDES\ConfigGuide_ProjectileNames.txt",
"source": "neurodr0me-RRRCore-3.1.4",
"target": "",
"time": 1619783002000
},
{
"relPath": "CONFIG GUIDES\ConfigGuide_SpecialAttackDefinitions.txt",
"source": "neurodr0me-RRRCore-3.1.4",
"target": "",
"time": 1619633008000
},
{
"relPath": "SeedTotem\SeedTotem.dll",
"source": "SeedTotem-876-4-3-3-1697235558",
"target": "",
"time": 1697235482000
},
{
"relPath": "SeedTotem\seed-totem-custom-requirements.json",
"source": "SeedTotem-876-4-3-3-1697235558",
"target": "",
"time": 1633964298000
},
{
"relPath": "SeedTotem\Translations\French\SeedTotem.french.json",
"source": "SeedTotem-876-4-3-3-1697235558",
"target": "",
"time": 1633964299000
},
{
"relPath": "SeedTotem\Translations\Russian\SeedTotem.russian.json",
"source": "SeedTotem-876-4-3-3-1697235558",
"target": "",
"time": 1693600626000
},
{
"relPath": "SeedTotem\Translations\Spanish\SeedTotem.spanish.json",
"source": "SeedTotem-876-4-3-3-1697235558",
"target": "",
"time": 1633964299000
},
{
"relPath": "SeedTotem\Translations\English\SeedTotem.english.json",
"source": "SeedTotem-876-4-3-3-1697235558",
"target": "",
"time": 1693600626000
},
{
"relPath": "FineWoodPieces.dll",
"source": "blacks7ar-FineWoodPieces-1.3.0",
"target": "",
"time": 1697480722000
},
{
"relPath": "FineWoodPieces.English.yml",
"source": "blacks7ar-FineWoodPieces-1.3.0",
"target": "",
"time": 1697480620000
},
{
"relPath": "VNEI.dll",
"source": "MSchmoecker-VNEI-0.12.1",
"target": "",
"time": 1696497890000
},
{
"relPath": "VNEI.xml",
"source": "MSchmoecker-VNEI-0.12.1",
"target": "",
"time": 1696497890000
},
{
"relPath": "SpeedyPaths.dll",
"source": "Nextek-SpeedyPaths-1.0.8",
"target": "",
"time": 1686675876000
},
{
"relPath": "OdinHorse.dll",
"source": "OdinPlus-OdinHorse-1.2.6",
"target": "",
"time": 1697578378000
},
{
"relPath": "OdinHorse.English.yml",
"source": "OdinPlus-OdinHorse-1.2.6",
"target": "",
"time": 1692825437000
},
{
"relPath": "OdinHorse.Polish.yml",
"source": "OdinPlus-OdinHorse-1.2.6",
"target": "",
"time": 1682401676000
},
{
"relPath": "OdinHorse.German.yml",
"source": "OdinPlus-OdinHorse-1.2.6",
"target": "",
"time": 1697578908000
},
{
"relPath": "CHANGELOG.md",
"source": "OdinPlus-OdinHorse-1.2.6",
"target": "",
"time": 1697579052000
},
{
"relPath": "OdinCampsite.dll",
"source": "OdinPlus-OdinCampsite-1.5.3",
"target": "",
"time": 1697578334000
},
{
"relPath": "OdinCampsite.English.yml",
"source": "OdinPlus-OdinCampsite-1.5.3",
"target": "",
"time": 1686847696000
},
{
"relPath": "OdinCampsite.German.yml",
"source": "OdinPlus-OdinCampsite-1.5.3",
"target": "",
"time": 1697578935000
},
{
"relPath": "OdinCampsite.Spanish.yml",
"source": "OdinPlus-OdinCampsite-1.5.3",
"target": "",
"time": 1686847696000
},
{
"relPath": "OdinCampsite.Polish.yml",
"source": "OdinPlus-OdinCampsite-1.5.3",
"target": "",
"time": 1686847696000
},
{
"relPath": "OdinTrainingPlace.English.yml",
"source": "OdinPlus-OdinTrainingPlace-1.5.3",
"target": "",
"time": 1686847728000
},
{
"relPath": "OdinTrainingPlace.dll",
"source": "OdinPlus-OdinTrainingPlace-1.5.3",
"target": "",
"time": 1697578390000
},
{
"relPath": "OdinTrainingPlace.Polish.yml",
"source": "OdinPlus-OdinTrainingPlace-1.5.3",
"target": "",
"time": 1686847728000
},
{
"relPath": "OdinTrainingPlace.Spanish.yml",
"source": "OdinPlus-OdinTrainingPlace-1.5.3",
"target": "",
"time": 1686847728000
},
{
"relPath": "OdinBear.dll",
"source": "OdinPlus-OdinBear-1.2.8",
"target": "",
"time": 1697578299000
},
{
"relPath": "OdinBear.Polish.yml",
"source": "OdinPlus-OdinBear-1.2.8",
"target": "",
"time": 1686847706000
}

Priority
Estimate how important this problem is. Choose Medium if you don't know.

  • High (XStorage does not work at all anymore)
@Augure34 Augure34 added the bug Something isn't working label Oct 18, 2023
@Augure34
Copy link
Author

I'm going to create a pull request for it if that's okay with you. Beyond that I think it works perfectly fine with Project Auga and just need a few null safety check

@SpikeHimself
Copy link
Owner

SpikeHimself commented Oct 18, 2023

Pull requests are welcome! I don't have Auga myself and don't intend to install it, but if you can stop it crashing by catching a null value that'd be fine with me 👍

@SpikeHimself SpikeHimself added the compatibility Other mods might be involved label Oct 18, 2023
@Augure34
Copy link
Author

Sadly my attempt did not work, Auga is clearly messing with containers UI too much to use both. Do you use/recommend a UI mod that's XStorage friendly?

@SpikeHimself
Copy link
Owner

I was afraid that would be the case. XStorage relies on vanilla container layout a lot. I don't use any UI altering mods myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility Other mods might be involved
Projects
None yet
Development

No branches or pull requests

2 participants