Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datetime for repost_time #194

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thekingofcity
Copy link
Member

@thekingofcity thekingofcity commented Mar 3, 2020

Use system's cert instead of disable InsecureRequestWarning

https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
https://urllib3.readthedocs.io/en/latest/user-guide.html#ssl

https://stackoverflow.com/questions/42982143/python-requests-how-to-use-system-ca-certificates-debian-ubuntu
https://stackoverflow.com/a/33717517/1695680

In this PR, we use system's cert rather than third-party certs. However, this will downgrade the compatibility since only ubuntu(debian) use this path.

@thekingofcity thekingofcity changed the title Use system's cert instead of disable InsecureRequestWarning datetime for repost_time May 6, 2020
@thekingofcity
Copy link
Member Author

In 4d80e0b, the create time for repost was updated to use datetime(python) and Datetime(mysql). This is a BREAKING change for the current project and means no more compactability for the previous database schema. However, by extracting the common create time parser, the repost and comment tasks can be maintained at once. And also the reposts can be filtered by create time via where. So this should be a helpful update.

Since the last PR heard no comments till today, I may merge this in the coming few weeks if there is still no any comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant