Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for better diagrams #8

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Fix for better diagrams #8

merged 1 commit into from
Jul 7, 2022

Conversation

rowleya
Copy link
Member

@rowleya rowleya commented Jul 7, 2022

Needed by SpiNNakerManchester/PACMAN#436 but only when the config option is enabled

@rowleya rowleya requested a review from Christian-B July 7, 2022 11:25
@rowleya
Copy link
Member Author

rowleya commented Jul 7, 2022

Looks like there are some whitespace changes too. See below for non-whitespace link:
https://github.com/SpiNNakerManchester/SpiNNer/pull/8/files?diff=split&w=1

@mossblaser
Copy link
Contributor

Do you have any samples of the new diagrams? (Always nice to see how things are going in SpiNNaker land all these years later!)

Hope all is well and sending all the best!

@rowleya
Copy link
Member Author

rowleya commented Jul 7, 2022

Do you have any samples of the new diagrams? (Always nice to see how things are going in SpiNNaker land all these years later!)

The only real changes here are:

  1. Allow the chips to be coloured
  2. Allow drawing of non-wrapped boards

Example of the placement of the microcircuit during debugging:
tmpxz9zak_3 rpt

@rowleya rowleya merged commit 34e8846 into master Jul 7, 2022
@rowleya rowleya deleted the reduce_overhead branch July 7, 2022 14:51
@mossblaser
Copy link
Contributor

That's really cool! (Also what a big simulation!)

If it's of any use I don't know if you remember this tool: https://github.com/project-rig/rig-par-diagram It's a little rig-oriented but might be useful if you ever want routing information (or core-level info).

@rowleya
Copy link
Member Author

rowleya commented Jul 8, 2022

If it's of any use I don't know if you remember this tool: https://github.com/project-rig/rig-par-diagram It's a little rig-oriented but might be useful if you ever want routing information (or core-level info).

I had forgotten that one, but will definitely look it up - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants