-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pylint default #267
Merged
Merged
Pylint default #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2024
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr and later similar (but independent) prs make pylint checking stricter and also more constant between repositories.
I have done my best to only do one type of change per commit so reviewing the commits may be easiest.
Changes include:
Using a global rcfile https://github.com/SpiNNakerManchester/SupportScripts/blob/master/actions/pylint/strict_rcfile
Rather than one per repository
A global spelling exceptions list https://github.com/SpiNNakerManchester/SupportScripts/blob/master/actions/pylint/default_dict.txt
A pylint.bash file to make it easier to run pylint manually/locally using as close as possible to the github actions settings.
To support the pylint.bash finding other repositories without requiring them to be in the path
Note: The changes to support scripts are already in master as impossible to test otherwise!
A number of spelling changes found by either github or running locally.
The code changes are limited to
-refactors some method or param names
Similar prs that can be done in any order:
SpiNNakerManchester/SpiNNMachine#236
SpiNNakerManchester/SpiNNMan#391
SpiNNakerManchester/PACMAN#541
SpiNNakerManchester/SpiNNFrontEndCommon#1157
SpiNNakerManchester/sPyNNaker#1437
tested by http://apollo.cs.man.ac.uk:8080/blue/organizations/jenkins/Integration%20Tests/detail/pylint_default/3/pipeline