Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interdimensional compatibility #516

Merged
merged 53 commits into from
Nov 28, 2023
Merged

Interdimensional compatibility #516

merged 53 commits into from
Nov 28, 2023

Conversation

rowleya
Copy link
Member

@rowleya rowleya commented May 25, 2023 •
edited
Loading

Part of SpiNNakerManchester/sPyNNaker#1345.

Fixes multidimensional support to work between vertices of any dimensionality.

Christian-B and others added 30 commits March 10, 2023 15:54
@Christian-B
Split Slice Object into simple Slice and Multi Deminsional Slice
aec9fd6
@Christian-B
better support for md slices
4b29e56
@Christian-B
flake8
6bd5549
@Christian-B
dont need atoms shape for 1d raster ids
bdb1205
@Christian-B
merged in master
c5d4cea
@Christian-B
merged in master
5ab7669
@Christian-B
merge
8e80832
@Christian-B
merged in master
c04ca7f
@Christian-B
merged in master
280db5d
@Christian-B
merged in master
4590488
@Christian-B
merged in master
9ec66e0
@Christian-B
merged in master
910ca6f
@Christian-B
merge
330d8d2
@Christian-B
merged in master
6fc7489
@Christian-B
merged in master
9fcfc51
@Christian-B
merged in master
c696ef3
@Christian-B
merged in master
8d0050d
@Christian-B
merge
86a4207
@Christian-B
remove test for stuff removed
585b77e
@Christian-B
fix overirde
597f9c7
@Christian-B
fix merge
087851f
@rowleya
Update functions for use without fields
a27f321
@rowleya
No need for this any more
16da918
@rowleya
Get power of 2 to a common place
24ed9e3
@rowleya
Make things public that help outside
6af032b
@rowleya
Avoid merging when the mask isn't right
af33f03
@rowleya
Merge branch 'master' into interdimensional_compatibility
3c968e2
@rowleya
Merge remote-tracking branch 'github/md_slice' into
a8e0273 
interdimensional_compatibility
@rowleya
Ensure that nD vertices are divisible by max_atoms_per_core
f3d4846
@rowleya
Merge branch 'master' into interdimensional_compatibility
a94d7a7
@coveralls
Copy link

coveralls commented Sep 15, 2023 •
edited
Loading

Coverage Status

coverage: 84.31% (+0.2%) from 84.079%
when pulling 699d909 on interdimensional_compatibility
into 1d0bcdc on master.

rowleya and others added 18 commits September 18, 2023 09:55
@rowleya
Merge branch 'master' into interdimensional_compatibility
7c9c3aa
@rowleya
Merge branch 'interdimensional_compatibility' of https://github.com/S…
f1bb2b0 
…piNNakerManchester/PACMAN.git into interdimensional_compatibility
@rowleya
Merge branch 'master' into interdimensional_compatibility
8dee34e
@rowleya
Merge branch 'master' into interdimensional_compatibility
efd1dd1
@rowleya
Merge branch 'master' into interdimensional_compatibility
6c8f9b9
@rowleya
Merge branch 'master' into interdimensional_compatibility
c91a37b
@rowleya
Move code here for vertices too
bcf5a39
@rowleya
Fix doc
d000d6e
@rowleya
Fix and test
95ba9d1
@rowleya
Add and test reversal functions
c25b6f6
@rowleya
Merge branch 'master' into interdimensional_compatibility
d7368d5
@rowleya
Flake8
4e6386c
@rowleya
Fix typing
ea7491a
@rowleya
Fix here too
493fe1f
@rowleya
Remove unused
8d9aa2a
@rowleya
More type fixes
83799a2
@rowleya
Merge branch 'master' into interdimensional_compatibility
4cdd87b
@Christian-B
by default n_atoms == app_vertex.get_max_atoms_per_core
13466bb
Christian-B
Christian-B approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@Christian-B Christian-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok as is

@rowleya rowleya marked this pull request as ready for review November 28, 2023 08:01
@rowleya rowleya mentioned this pull request Nov 28, 2023
Merged
@Christian-B Christian-B merged commit 084f2c7 into master Nov 28, 2023
5 checks passed
@Christian-B Christian-B deleted the interdimensional_compatibility branch November 28, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christian-B Christian-B Christian-B approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rowleya @coveralls @Christian-B