Sanity check jobs #1215
Merged
Sanity check jobs #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1136.
Reasons should now be provided; this has been manually tested for various things. The implementation is that jobs are simply not queued if they fail the checks. The checks are similar to the allocation checks, but instead of checking if the boards "can_be_allocated" they check simply that they are functional. This means that they could be allocated, though might be busy now.
This makes #1135 unnecessary, so should be closed if this is merged.
Testing done with SpiNNakerManchester/IntegrationTests#311 (which is to say, the server is currently running this code, so the integration tests are really just running master code against it).