Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multi-document mdoc device response #186

Conversation

TimoGlastra
Copy link
Contributor

Needs Sphereon-Opensource/SSI-SDK#263 for the multi-document to work, but without that PR it still works with the current document for single doc.

Adds support for extracting the correct mdoc document from a device response, rather than just the first. It does this by matching on the input_descriptor.id according to 18013-7.

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.69%. Comparing base (0b9c601) to head (b40cbc5).
Report is 5 commits behind head on feature/mdoc-parsing.

Files with missing lines Patch % Lines
lib/evaluation/evaluationClientWrapper.ts 66.66% 4 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/mdoc-parsing     #186      +/-   ##
========================================================
- Coverage                 92.80%   92.69%   -0.12%     
========================================================
  Files                        66       66              
  Lines                      2739     2750      +11     
  Branches                    719      651      -68     
========================================================
+ Hits                       2542     2549       +7     
- Misses                      192      200       +8     
+ Partials                      5        1       -4     
Flag Coverage Δ
unittest 92.69% <66.66%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanderPostma sanderPostma merged commit 4cabdd3 into Sphereon-Opensource:feature/mdoc-parsing Nov 1, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants