Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move group collection to end of our ldap queries #175

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

rvazarkar
Copy link
Contributor

Description

Group collection has the highest incidence of query failure of all of our different collection methods. Move this to the end of collection to allow everything else to collect as best as possible.

Motivation and Context

https://specterops.atlassian.net/browse/BED-5061

How Has This Been Tested?

No tests required, this is a simple logic change for ordering

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@rvazarkar rvazarkar enabled auto-merge (squash) November 21, 2024 16:24
@rvazarkar rvazarkar merged commit c953260 into v4 Nov 21, 2024
3 checks passed
@rvazarkar rvazarkar deleted the move_group_collection branch November 21, 2024 16:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants