fix: adds a rev number to cache creation to prevent deserialization e…

…rrors
SpecterOps · Nov 29, 2023 · dbb16e9 · dbb16e9
1 parent fd82e42
commit dbb16e9
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 18 deletions.
diff --git a/src/CommonLib/Cache.cs b/src/CommonLib/Cache.cs
@@ -20,7 +20,7 @@ public class Cache
         //
         // [DataMember]private ConcurrentDictionary<string, string> _valueToIDCache;
 
-        private static Version defaultVersion = new(1, 0, 0);
+        private static Version defaultVersion = new(1, 0, 0, 0);
 
         private Cache()
         {

diff --git a/test/unit/CacheTest.cs b/test/unit/CacheTest.cs
@@ -18,7 +18,7 @@ public CacheTest(ITestOutputHelper testOutputHelper)
         public void Cache_TestNewCache()
         {
             var cache = Cache.CreateNewCache();
-            Assert.Equal(cache.CacheCreationVersion, new Version(1,0,0));
+            Assert.Equal(cache.CacheCreationVersion, new Version(1,0,0, 0));
             var version = new Version(1, 0, 1);
             cache = Cache.CreateNewCache(version);
             var time = DateTime.Now.Date;

diff --git a/test/unit/CommonLibHelperTests.cs b/test/unit/CommonLibHelperTests.cs
@@ -193,14 +193,6 @@ public void ConvertFileTimeToUnixEpoch_Null_NegativeOne()
             Assert.Equal(-1, result);
         }
 
-        [Fact]
-        public void ConvertFileTimeToUnixEpoch_WrongFormat_FortmatException()
-        {
-            Exception ex =
-                Assert.Throws<FormatException>(() => SharpHoundCommonLib.Helpers.ConvertFileTimeToUnixEpoch("asdsf"));
-            Assert.Equal("Input string was not in a correct format.", ex.Message);
-        }
-
         [Fact]
         public void ConvertFileTimeToUnixEpoch_BadInput_CastExceptionReturnsNegativeOne()
         {
@@ -219,13 +211,5 @@ public void ConvertTimestampToUnixEpoch_ValidTimestamp_ValidUnixEpoch()
 
             Assert.Equal(d.ToUniversalTime().Date, testDate);
         }
-
-        [Fact]
-        public void ConvertTimestampToUnixEpoch_InvalidTimestamp_FormatException()
-        {
-            Exception ex = Assert.Throws<FormatException>(() =>
-                SharpHoundCommonLib.Helpers.ConvertFileTimeToUnixEpoch("-201adsfasf12180244"));
-            Assert.Equal("Input string was not in a correct format.", ex.Message);
-        }
     }
 }