Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BED-5069 feat: add sso config options to providers #990

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

BED-5069 feat: add sso config options to providers #990

wants to merge 5 commits into from
+457 −71

Conversation

mistahj67
Copy link
Contributor

@mistahj67 mistahj67 commented Dec 2, 2024 •
edited
Loading

Description

  • Moved SAML / OIDC components under SSOProvider directory for easier management
  • Added SSOProviderConfigForm component to both UpsertSAMLProviderForm & UpsertOIDCProviderForm

Motivation and Context

This PR addresses: BED-5069

Why is this change required? What problem does it solve?
Provides ability to configure sso providers with auto provisioning support and display the configured values as well

How Has This Been Tested?

Unit tests / locally

Screenshots (optional):

image
image

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

@mistahj67 mistahj67 added the user interface A pull request containing changes affecting the UI code. label Dec 2, 2024
@mistahj67 mistahj67 self-assigned this Dec 2, 2024
@mistahj67 mistahj67 force-pushed the BED-5009 branch 4 times, most recently from 7d0151f to b21b974 Compare December 2, 2024 20:41
@mistahj67 mistahj67 changed the title BED-5009 feat: add sso config options to providers BED-5069 feat: add sso config options to providers Dec 2, 2024
@mistahj67 mistahj67 force-pushed the BED-5009 branch 2 times, most recently from 6f08b90 to 67ca6ac Compare December 3, 2024 17:37
@mistahj67 mistahj67 marked this pull request as ready for review December 3, 2024 17:49
@benwaples
Copy link
Contributor

blocked until API side it complete

@benwaples benwaples added the blocked This pull request cannot be completed and should not be merged label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwaples benwaples benwaples left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@mistahj67 mistahj67

Labels
blocked This pull request cannot be completed and should not be merged user interface A pull request containing changes affecting the UI code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistahj67 @benwaples