Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add conversion logic to EIN to fix badly typed properties #909

Merged
merged 6 commits into from
Oct 28, 2024

Conversation

rvazarkar
Copy link
Contributor

@rvazarkar rvazarkar commented Oct 22, 2024

Description

Adds logic to EIN to convert certain string properties to integers/bools as necessary.

Counterpart to BloodHoundAD/SharpHoundCommon#173

Motivation and Context

This PR addresses: https://specterops.atlassian.net/browse/BED-4928

How Has This Been Tested?

Unit tests written

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

packages/go/ein/ad.go Outdated Show resolved Hide resolved
packages/go/ein/ad.go Show resolved Hide resolved
@rvazarkar rvazarkar merged commit 010bf3e into main Oct 28, 2024
4 checks passed
@rvazarkar rvazarkar deleted the BED-4928 branch October 28, 2024 14:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants