BED-5268: Tiering create selector #1211

AD7ZJ · 2025-03-12T00:52:26Z

Description

Implement the api/v2/asset-group-labels/{%s}/selectors endpoint.

Motivation and Context

This PR addresses: https://specterops.atlassian.net/browse/BED-5268

How Has This Been Tested?

Added unit tests for resource and database methods. Tested that the endpoint works using bruno.

Screenshots (optional):

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

I have met the contributing prerequisites
- Assigned myself to this PR
- Added the appropriate labels
- Associated an issue: Issues and Pull Requests README #672
- Read the Contributing guide: https://github.com/SpecterOps/BloodHound/wiki/Contributing
I have ensured that related documentation is up-to-date
- Code comments (GoDocs / JSDocs)
I have followed proper test practices
- Added/updated tests to cover my changes
- All new and existing tests passed

…elSelectorID

tiering selectors.

allowed cypher query complexity. All previously existing calls to it have been updated to use MaxQueryComplexityWeightAllowed so the overall behavior is unchanged.

Fixed unit test of CreateAssetGroupLabel()

cmd/api/src/api/v2/assetgrouplabels.go

cmd/api/src/database/migration/migrations/v7.2.0.sql

mistahj67

I think this is nearly there, mostly naming nits but blocked for migration change and a few missing considerations

cmd/api/src/database/migration/migrations/v7.2.0.sql

cmd/api/src/queries/graph.go

packages/go/dawgs/drivers/pg/query/sql/schema_up.sql

cmd/api/src/api/v2/assetgrouplabels.go

…Ops/BloodHound into BED-5268-Tiering-Create-Selector

cmd/api/src/api/registration/v2.go

cmd/api/src/api/v2/assetgrouplabels_test.go

cmd/api/src/database/assetgrouplabels.go

cmd/api/src/database/migration/migrations/v7.2.0.sql

cmd/api/src/model/assetgrouplabels.go

cmd/api/src/api/registration/v2.go

cmd/api/src/api/v2/assetgrouplabels.go

cmd/api/src/database/assetgrouplabels.go

cmd/api/src/database/migration/migrations/v7.2.0.sql

cmd/api/src/model/assetgrouplabels.go

log correctly.

fills out correctly.

…te-Selector

cmd/api/src/api/v2/assetgrouplabels.go

cmd/api/src/database/assetgrouplabels.go

cmd/api/src/database/migration/migrations/v7.2.0.sql

cmd/api/src/database/db.go

packages/go/dawgs/drivers/pg/query/sql/schema_up.sql

Add position and auto_certify to the automatic Tier zero insertion.

…te-Selector

cmd/api/src/api/v2/attack_path.go

cmd/api/src/api/v2/assetgrouptags.go

cmd/api/src/database/assetgrouptags.go

cmd/api/src/api/v2/assetgrouptags_test.go

cmd/api/src/database/assetgrouptags.go

cmd/api/src/api/v2/attack_path.go

cmd/api/src/model/assetgrouphistory.go

cmd/api/src/database/assetgrouphistory.go

some review findings in unit test.

needed).

cmd/api/src/database/migration/migrations/v7.2.0.sql

cmd/api/src/database/migration/migrations/v7.3.0.sql

cmd/api/src/model/assetgrouptags.go

cmd/api/src/database/assetgrouptags.go

v7.2.0.sql.

field. Validate that all selector seeds are of the same type.

tag.

mistahj67

Appreciate the patience with the feedback, code LGTM

computator

I think this all looks good!

AD7ZJ added 4 commits March 11, 2025 16:03

Add URIPathVariableAssetGroupLabelID and URIPathVariableAssetGroupLab…

9d007cb

…elSelectorID

Add tier managment feature flag and some API error responses related to

646132e

tiering selectors.

Change PrepareCypherQuery() to accept a parameter for the maximum

03f3798

allowed cypher query complexity. All previously existing calls to it have been updated to use MaxQueryComplexityWeightAllowed so the overall behavior is unchanged.

Move asset group label stuff to bhce

d9421bc

mintlify bot deployed to staging - docs March 12, 2025 00:52 View deployment

Add kind table to migration for testing purposes.

dd7586d

Fixed unit test of CreateAssetGroupLabel()

computator reviewed Mar 13, 2025

View reviewed changes

cmd/api/src/api/v2/assetgrouplabels.go Outdated Show resolved Hide resolved

cmd/api/src/database/migration/migrations/v7.2.0.sql Outdated Show resolved Hide resolved

AD7ZJ added 2 commits March 13, 2025 13:59

Add a comment about the kind table we added to the db migratoin.

38bfb71

if auth.GetUserFromAuthCtx() fails, log an error and return 500

146de75

mistahj67 requested changes Mar 13, 2025

View reviewed changes

mistahj67 and others added 3 commits March 13, 2025 15:23

feat: add asset group history db methods

fc9e26c

Make regular db transactions into AuditableTransaction()

afd3f0a

Merge branch 'BED-5268-Tiering-Create-Selector' of github.com:Specter…

42966a8

…Ops/BloodHound into BED-5268-Tiering-Create-Selector

computator reviewed Mar 14, 2025

View reviewed changes

mistahj67 reviewed Mar 14, 2025

View reviewed changes

Implement review suggestions

860d6db

AD7ZJ force-pushed the BED-5268-Tiering-Create-Selector branch from b2ff321 to 860d6db Compare March 14, 2025 17:27

Implement a few more review findings

eeb6e87

AD7ZJ requested a review from mistahj67 March 14, 2025 17:32

AD7ZJ added 3 commits March 14, 2025 10:58

Populate the selector model at the beginning so it fills out the audit

d941650

log correctly.

Populate model at beginning of CreateAssetGroupLabel() so audit log

fd6b57c

fills out correctly.

Merge remote-tracking branch 'origin/main' into BED-5268-Tiering-Crea…

f58faa1

…te-Selector

mintlify bot deployed to staging - docs March 14, 2025 21:31 View deployment

Ran PFC

2a051bd

mistahj67 reviewed Mar 14, 2025

View reviewed changes

AD7ZJ added 5 commits March 17, 2025 12:03

Cleanup

5fb219d

Renamed label to tag.

dca7cec

Fixed a few issues related to the rename from label to tag.

7967418

Fixed a few more naming issues.

44dd135

Rename files from assetgrouplabels to assetgrouptags.

04f9a94

mistahj67 reviewed Mar 18, 2025

View reviewed changes

cmd/api/src/database/db.go Outdated Show resolved Hide resolved

packages/go/dawgs/drivers/pg/query/sql/schema_up.sql Outdated Show resolved Hide resolved

AD7ZJ added 5 commits March 18, 2025 10:09

Nix'd a couple missed 'label' terms in comments.

bae1ae2

Add position and auto_certify to the automatic Tier zero insertion.

Add position and requireCertify parameters to CreateAssetGroupTag()

fe048a4

Fix RETURNING * statements to be explicit what columns are returned.

684dccc

Merge remote-tracking branch 'origin/main' into BED-5268-Tiering-Crea…

d7f040d

…te-Selector

Fixed an incorrectly named variable.

927de0c

stephanieslamb reviewed Mar 18, 2025

View reviewed changes

cmd/api/src/api/v2/attack_path.go Outdated Show resolved Hide resolved

Rename migration v7.2.0 to v7.3.0.

bae68cd

computator reviewed Mar 18, 2025

View reviewed changes

cmd/api/src/api/v2/assetgrouptags.go Outdated Show resolved Hide resolved

cmd/api/src/api/v2/assetgrouptags.go Outdated Show resolved Hide resolved

cmd/api/src/database/assetgrouptags.go Show resolved Hide resolved

computator requested changes Mar 18, 2025

View reviewed changes

AD7ZJ added 4 commits March 18, 2025 17:26

Re-ordered the api handler and cleaned up some variable names. Fixed

fc95f5c

some review findings in unit test.

Fixed more review findings.

049f5f7

Moved common error constants out of attack_path.go

d3d31e3

Change areCypherSelectorSeedsValid() to only return an error (no bool

09ce738

needed).

mistahj67 requested changes Mar 19, 2025

View reviewed changes

cmd/api/src/database/migration/migrations/v7.2.0.sql Show resolved Hide resolved

cmd/api/src/database/migration/migrations/v7.3.0.sql Outdated Show resolved Hide resolved

cmd/api/src/database/migration/migrations/v7.3.0.sql Outdated Show resolved Hide resolved

mistahj67 reviewed Mar 19, 2025

View reviewed changes

cmd/api/src/model/assetgrouptags.go Outdated Show resolved Hide resolved

computator reviewed Mar 19, 2025

View reviewed changes

cmd/api/src/database/assetgrouptags.go Outdated Show resolved Hide resolved

AD7ZJ added 6 commits March 19, 2025 14:36

Revert bae68cd which deleted

eddb2e4

v7.2.0.sql.

Fix a few more review findings.

d4acbf8

CreateAssetGroupHistoryRecord() was missing filling out the created_at

6db70f8

field. Validate that all selector seeds are of the same type.

cleanup on unit tests. Clarify error response on validateSelectorSeeds()

d597b53

re-write the check for null position and require_certify when creating a

1178004

tag.

Fix unit test for CreateAssetGroupTagSelector()

1f2f2ce

mistahj67 approved these changes Mar 20, 2025

View reviewed changes

computator approved these changes Mar 20, 2025

View reviewed changes

AD7ZJ merged commit 61a0a0f into main Mar 20, 2025
8 checks passed

AD7ZJ deleted the BED-5268-Tiering-Create-Selector branch March 20, 2025 16:58

github-actions bot locked and limited conversation to collaborators Mar 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BED-5268: Tiering create selector #1211

BED-5268: Tiering create selector #1211

AD7ZJ commented Mar 12, 2025 •

edited

Loading

mistahj67 left a comment

mistahj67 left a comment

computator left a comment

BED-5268: Tiering create selector #1211

BED-5268: Tiering create selector #1211

Conversation

AD7ZJ commented Mar 12, 2025 • edited Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots (optional):

Types of changes

Checklist:

mistahj67 left a comment

Choose a reason for hiding this comment

mistahj67 left a comment

Choose a reason for hiding this comment

computator left a comment

Choose a reason for hiding this comment

AD7ZJ commented Mar 12, 2025 •

edited

Loading