Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.work for go version #1059

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Conversation

steve-embling
Copy link
Contributor

@steve-embling steve-embling commented Jan 9, 2025

A potential fix for

go: downloading go1.23 (linux/amd64)
go: download go1.23 for linux/amd64: toolchain not available

When building bh-dev.

Description

Building of development version on my machine fails with toolchain not available. This changes to go1.23.0 which is enough for me to get it over the line.

Motivation and Context

This probably isn't the correct fix for something environmental or user error, but even as PR is closed it might save someone some time when searching issues for the error. Also pinning to .0 is probably bad.

Intent is to raise this and close it as invalid, but at least the information can be found.

How Has This Been Tested?

I tested that build then completed only.

Types of changes

  • Chore

Checklist:

Fix for
go: downloading go1.23 (linux/amd64)
go: download go1.23 for linux/amd64: toolchain not available
Copy link

github-actions bot commented Jan 9, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@steve-embling
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@irshadaj irshadaj added the api A pull request containing changes affecting the API code. label Jan 10, 2025
Copy link
Contributor

@zinic zinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has my approval. Thanks for the PR!

@zinic zinic merged commit 319bb31 into SpecterOps:main Jan 11, 2025
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api A pull request containing changes affecting the API code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants