Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-5133 #1048

Open
wants to merge 12 commits into
base: BED-5083
Choose a base branch
from
Open

BED-5133 #1048

wants to merge 12 commits into from

Conversation

benwaples
Copy link
Contributor

@benwaples benwaples commented Jan 3, 2025

Description

This PR:

  • Exports the Domain type from api-client and uses a string literal for Domain.type
  • Adds a type for the DataSelector to add type safety for the -platform options in that component.
  • Support for passing options to useAvailableDomains hook.
  • Adds MappedStringLiteral which will map all values of a string literal to specified values
  • Updates to posture-history and finding-trends to match upcoming API contract changes

Motivation and Context

Implements BED-5133

How Has This Been Tested?

added unit tests and manually tested

Screenshots (optional):

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

@benwaples benwaples marked this pull request as draft January 3, 2025 23:37
@benwaples benwaples self-assigned this Jan 10, 2025
@benwaples benwaples added enhancement New feature or request user interface A pull request containing changes affecting the UI code. labels Jan 10, 2025
@elikmiller elikmiller changed the base branch from main to BED-5083 January 10, 2025 18:53
@benwaples benwaples changed the title Bed 5133 BED-5133 Jan 11, 2025
@benwaples benwaples marked this pull request as ready for review January 11, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user interface A pull request containing changes affecting the UI code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant