Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-5178 fix: OIDC default scopes #1041

Merged
merged 1 commit into from
Dec 24, 2024
Merged

BED-5178 fix: OIDC default scopes #1041

merged 1 commit into from
Dec 24, 2024

Conversation

mistahj67
Copy link
Contributor

Description

Remove the invalid scopes from the OIDC login handler

Motivation and Context

Currently the login handler incorrectly requests claims inside the scopes parameter. This breaks the stricter IDPs such as Microsoft Entra

This PR addresses: BED-5178

Why is this change required? What problem does it solve?

How Has This Been Tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@mistahj67 mistahj67 added bug Something isn't working api A pull request containing changes affecting the API code. labels Dec 24, 2024
@mistahj67 mistahj67 self-assigned this Dec 24, 2024
@mistahj67 mistahj67 merged commit d4d10bf into main Dec 24, 2024
4 checks passed
@mistahj67 mistahj67 deleted the BED-5178 branch December 24, 2024 20:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api A pull request containing changes affecting the API code. bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants