-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BED-5013: Deprecate Create SAML Endpoint #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistahj67
requested changes
Dec 20, 2024
Co-authored-by: mistahj67 <[email protected]>
Co-authored-by: mistahj67 <[email protected]>
iustinum
added
documentation
Improvements or additions to documentation
api
A pull request containing changes affecting the API code.
labels
Dec 20, 2024
mistahj67
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM and locally tested
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api
A pull request containing changes affecting the API code.
documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new SSO endpoint
POST /api/v2/sso-providers/saml
to replace the existingPOST /api/v2/saml/providers
endpoint. The old endpoint is marked as deprecated, and OpenAPI documentation is updated accordingly.Motivation and Context
This PR addresses: BED-5013
By migrating to the new endpoint, we standardize SSO provider interactions and guide users away from the soon-to-be-removed SAML-specific endpoints.
How Has This Been Tested?
Screenshots (optional):
Types of changes
Checklist: