Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-4868 Wrong Reader Count for AZKeyVaults #1017

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

BED-4868 Wrong Reader Count for AZKeyVaults #1017

wants to merge 6 commits into from

Conversation

AD7ZJ
Copy link
Contributor

@AD7ZJ AD7ZJ commented Dec 13, 2024

Description

Added a field countLabel to the data returned by the endpoint in content.ts This can then be picked up by the EntityInfoDataTable so it can use the correct count for parent objects where needed.

Motivation and Context

This PR addresses: https://specterops.atlassian.net/browse/BED-4868

How Has This Been Tested?

Import the azure example data. Search for 'keyvault' in the explorer and select PHANTOMKEYVAULT-01. The key readers dialog should show 2, not 8.

I have also added a test to EntityInfoDataTable.test.tsx

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@AD7ZJ AD7ZJ requested review from urangel and removed request for urangel December 16, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants