add keyboard search feature #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi can i get a review on this please :-^ |
Sparsh1212
reviewed
Dec 14, 2021
src/components/AdvancedSearch.js
Outdated
Comment on lines
48
to
49
| const [new_array,setNew_array]=useState([]) | ||
| let [counter,setCounter]=useState(0) |
There was a problem hiding this comment.
Can we give more meaningful names to these states like: keyCounter and something more apt for new_array
Sparsh1212
requested changes
Dec 14, 2021
|
Hi, I have renamed the variables, and my prettier have added some auto formatting, that wont have impact on the application. changed single quote to double quote that is all, 9c819518-4870-4bd5-93fb-b4f32db959dc.mp4l |
Sparsh1212
requested changes
Dec 15, 2021
|
changed the quotes, and semi colon. although its a good convention to include semi-colon and double quotes to strings and single quotes for jsx , thanks :-) |
Sparsh1212
requested changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Keyboard search functionality,User can search for a keyword and from the suggestion list user can fill the input with up and down arrow keys.