-
Notifications
You must be signed in to change notification settings - Fork 36
TASK-5830: TLSRPT #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
TASK-5830: TLSRPT #791
Conversation
❌ Deploy Preview for support-docs failed.
|
in the RFC: https://datatracker.ietf.org/doc/html/rfc8460. | ||
|
||
The following JSON fields are not defined in the RFC: | ||
* `epoch` - timestamp in epoch of when the hook is invoked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) wording seems a little awkward. Maybe "epoch time" or "UNIX epoch"?
|
||
The following JSON fields are not defined in the RFC: | ||
* `epoch` - timestamp in epoch of when the hook is invoked | ||
* `type` - whether the data is for a successful TLS connection or a failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 'type' rather than maybe 'status' or 'success'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
report type. I prefer to keep it, and the doc already passed to SMX. I'm reluctant to change is unless it's absolutely necessary.
The following JSON fields are not defined in the RFC: | ||
* `epoch` - timestamp in epoch of when the hook is invoked | ||
* `type` - whether the data is for a successful TLS connection or a failure. | ||
`0` - failure; `1` - success |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, these end up on the same line in the preview.
What Changed
How To Test or Verify
PR Checklist
Below are some checklists to follow for the correct procedure in different circumstance. The first list ("All PRs Checklist") should be followed for ALL PRs. The next 2 are additive to this list depending on what type of PR you are using.
For example: If you are submitting a content change to one of the support documents, your checklist would include the:
If you are submitting a feature addition, enhancement, or bug fix, your checklist would include the:
All PRs Checklist
team-FE
orteam-SAZ
)Content Changes Checklist
examples/article.md
in the root of the project directory and on the momentum doc's preface articleDevelopment Changes Checklist (some checks are automatic github actions and will not be listed here. ie. "all tests pass")
cypress/
directory in the root of the project