Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a catch statement to ignore forbidden images #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions Slingshot.CCB/Slingshot.CCB/Utilities/Translators/CcbPerson.cs
Original file line number Diff line number Diff line change
Expand Up @@ -228,13 +228,22 @@ public static Person Translate( XElement inputPerson )
// CCB encoded key expires too quickly, so download immediately instead of setting person.PersonPhotoUrl
Task.Run( () =>
{
// save image locally
var imageResponse = WebRequest.Create( imageURI ).GetResponse();
var imageStream = imageResponse.GetResponseStream();
var path = Path.Combine( ImportPackage.ImageDirectory, "Person_" + person.Id + ".jpg" );
using ( FileStream output = File.OpenWrite( path ) )
// Intentionally skip any damaged or troublesome images here:
try
{
imageStream.CopyTo( output );
// save image locally
var imageResponse = WebRequest.Create( imageURI ).GetResponse();
var imageStream = imageResponse.GetResponseStream();
var path = Path.Combine( ImportPackage.ImageDirectory, "Person_" + person.Id + ".jpg" );
using ( FileStream output = File.OpenWrite( path ) )
{
imageStream.CopyTo( output );
}
}
catch ( Exception )
{
// Continue and ignored forbidden files

}
} );
}
Expand Down