Add check for docker version to ensure the correct prune command #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
docker volume prunecommand does work the same way in Docker version 23.0 or greater, in that it now only removes anonymous volumes by default. unRAID version 6.12.8 updated Docker to version 24.0.9 (see release notes). To restore the original functionality one can add the--allflag to the command, which removes all dangling volumes.This change adds a check to Docker version and modifies the
docker volume prunecommand if using version 23.0 or greater.See Docker CLI issue #4028 for details.
How Has This Been Tested?
This has been tested on unRAID version 6.12.8 running Docker version 24.0.9, and also on a non-unRAID Linux machine running Docker version 20.10.25.