Add strong types in FRAM code and refactor ProgramId #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickKa
changed the title
PatrickKa
force-pushed
the
strong-types
branch
5 times, most recently
from
b9d097e
to
fb153f2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #312 +/- ##
==========================================
- Coverage 87.58% 87.53% -0.06%
==========================================
Files 28 28
Lines 701 706 +5
Branches 8 8
==========================================
+ Hits 614 618 +4
- Misses 87 88 +1 ☔ View full report in Codecov by Sentry. |
It is annoying because we often use constant-width integer types.
Also, give it the highest priority apart from the associated header, which automatically gets priority 0.
It is not about const-correctness, but about const-ness of local variables and we re not jumping on that bandwagon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308
Fixes #309