Support Packet V2 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cksum calculation accordingly
…essing to use new packetDef struct
andycate
requested changes
Jan 4, 2022
electron/Board.js
Outdated
|
|
||
| let offset = dataOffset; | ||
|
|
||
| for (const [_, parser, __] of packetDef[id]) { |
There was a problem hiding this comment.
Don't need the [id] after packetDef. Also not sure what the third value is in the array?
There was a problem hiding this comment.
Third value is the interpolator, could be removed but I included to remember that it could exist in the INBOUND_PACKET_DEF.
electron/Board.js
Outdated
Comment on lines
48
to
58
| calculateTimestamp(runTime) { | ||
| if (this.firstRecvTime < 0) { | ||
| /* TODO: consider using multiple packet offsets to reduce likelihood of noise causing the first receive time to | ||
| * deviate too significantly */ | ||
| this.firstRecvTime = Date.now() | ||
| } | ||
| if (this.firstRecvOffset < 0) { | ||
| this.firstRecvOffset = runTime | ||
| } | ||
| return runTime - this.firstRecvOffset + this.firstRecvTime | ||
| } |
There was a problem hiding this comment.
Be careful, because if a board disconnects and reconnects, it might have rebooted in between. Which would mean that the timestamp on the board would be different. So if the board ever disconnects, then on reconnection it should re-sync timestamps.
* Add debug message when INBOUND_PACKET has an undefined / unknown Packet ID * Reset timestamp sync when board disconnects * Update checksum calculation to use 256 as the modulus
…ch on dashboard and appropriate functions to send outbound command to turn on relay manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.