Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pre-check cleanup also in GH actions #680

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

martinmo
Copy link
Member

@martinmo martinmo commented Aug 2, 2024

Even if we want to completely switch to Zuul, it's not clear when this happens and in the meantime there is still plenty of opportunity that this is the reason for failed tests. The fix is rather easy, I just copied and slightly adapted the invocation from playbooks/pre_cloud.yaml.

@martinmo martinmo requested a review from mbuechse August 2, 2024 13:22
@martinmo martinmo self-assigned this Aug 2, 2024
@martinmo martinmo added SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10 labels Aug 2, 2024
Copy link
Contributor

@mbuechse mbuechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative!

@martinmo
Copy link
Member Author

martinmo commented Aug 2, 2024

Please note: I'll merge this on monday, because I fear that this might break something and I don't want to risk this right before the weekend :-)

@mbuechse mbuechse added this to the R7 (v8.0.0) milestone Aug 2, 2024
@martinmo
Copy link
Member Author

martinmo commented Aug 5, 2024

After having another look, I came to the conclusion that this can't work reliably: the workflows for one cloud can run in parallel, sometimes 4 at the same time (and not only because of the same schedule, they also run after the Docker image was built). Hence, with good timing, the cleanup will interfere with a run. This can be worked around by running the cleanup only for IaaS v4 checks (it is only needed there).

@martinmo martinmo merged commit 57479ad into main Aug 5, 2024
4 checks passed
@martinmo martinmo deleted the feat/run-cleanup-in-gh-actions branch August 5, 2024 07:16
@mbuechse
Copy link
Contributor

mbuechse commented Aug 5, 2024

I guess it would have been better in principle to define a separate cleanup job and make it a prerequisite of the compliance-test job. Since we want to abandon the Github jobs anyway (#672), we may opt to save us this effort.

@martinmo
Copy link
Member Author

martinmo commented Aug 5, 2024

I agree with both statements, this is why I just used the quick workaround 👍

OgarOgarovic pushed a commit that referenced this pull request Aug 27, 2024
Signed-off-by: Martin Morgenstern <[email protected]>
Signed-off-by: Ivan Vnučko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants