Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline entry for PCO Regions. #589

Merged
merged 4 commits into from
May 14, 2024
Merged

Multiline entry for PCO Regions. #589

merged 4 commits into from
May 14, 2024

Conversation

garloff
Copy link
Member

@garloff garloff commented May 9, 2024

No description provided.

@garloff garloff added enhancement New feature or request standards Issues / ADR / pull requests relevant for standardization & certification labels May 9, 2024
@garloff garloff self-assigned this May 9, 2024
@garloff
Copy link
Member Author

garloff commented May 9, 2024

Hmm, this breaks markdownlint.
Should we disable MD033?
But maybe there are good reasons to forbid inline HTML?
(Not that I think inline HTML is a good idea in general, but occasionally, it might be the only solution.)

@garloff
Copy link
Member Author

garloff commented May 9, 2024

Sidenote about the other CI fail: The TLS cert for the regio cloud HM is expired. This is addressed in PR #588.

@maxwolfs
Copy link
Member

maxwolfs commented May 9, 2024

RE: MD033: Let's do it the way we handled it within the docs page: https://github.com/SovereignCloudStack/docs/pull/193/files by disabling MD033 only for this file.

@berendt
Copy link
Member

berendt commented May 9, 2024

Sidenote about the other CI fail: The TLS cert for the regio cloud HM is expired. This is addressed in PR #588.

You can also keep it in. I finally have it on the list to repair by the beginning of next week (just In time for the summit..).

@garloff
Copy link
Member Author

garloff commented May 10, 2024

Sidenote about the other CI fail: The TLS cert for the regio cloud HM is expired. This is addressed in PR #588.

You can also keep it in. I finally have it on the list to repair by the beginning of next week (just In time for the summit..).

I want to merge now and I want to avoid ignoring CI fails.
If you can fix it within the next hour, I'll just hold back.
Otherwise, submit two PRs (one for Docs and one here) on Monday, please, to reenable the Health-Mon.
(Obviously, I'd love to have your health-mon in there!)

@berendt
Copy link
Member

berendt commented May 10, 2024

Sidenote about the other CI fail: The TLS cert for the regio cloud HM is expired. This is addressed in PR #588.

You can also keep it in. I finally have it on the list to repair by the beginning of next week (just In time for the summit..).

I want to merge now and I want to avoid ignoring CI fails. If you can fix it within the next hour, I'll just hold back. Otherwise, submit two PRs (one for Docs and one here) on Monday, please, to reenable the Health-Mon. (Obviously, I'd love to have your health-mon in there!)

Looks like this is already merged now. I will fix the HM on our site over the weekend and will re-add the link with a separate PR.

@garloff
Copy link
Member Author

garloff commented May 10, 2024

Looks like this is already merged now. I will fix the HM on our site over the weekend and will re-add the link with a separate PR.

We unfortunately have this list twice -- here in the README.md and in docs/standards/certification/overview.md
The latter was merged already. We should consolidate this in the future ... SovereignCloudStack/docs#166

Copy link
Member

@frosty-geek frosty-geek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garloff garloff merged commit 4bea713 into main May 14, 2024
6 checks passed
@garloff garloff deleted the feat/pco-multiline2 branch May 14, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request standards Issues / ADR / pull requests relevant for standardization & certification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants