Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidelines to write good conformance tests for k8s #221

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tonifinger
Copy link
Contributor

This PR contains guidelines and best practices on how to write good conformance tests for K8S by using Sonobuoy.

@tonifinger tonifinger linked an issue Aug 14, 2024 that may be closed by this pull request
@tonifinger tonifinger self-assigned this Aug 14, 2024
Copy link
Contributor

@mbuechse mbuechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for drafting this! I think we should address whatever Markdownlint says. Apart from that, I would ask you to be more brief and to the point. I suggest to use simple sentences, such as "First, we check whether all requirements of the development environment are met" (instead of "this can be used to") or "Next, we start the development Kind cluster" (instead of "Once ..., you can ..."). This kind of holding-hands step-by-step guide is appropriate, but I think we should also have a brief(!) descriptive overview as well. For instance, explain the structure of the test directory, the components that are involved in testing etc.

Comment on lines 1 to 6
---
title: SCS Conformance Test KaaS Sonobuoy
type:
status: Draft
track: Global
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the other files in this directory have a front matter, but I don't think that we are actually using it in the docs pages. It can be dropped, and it should be dropped, because it could confuse people.

status: Draft
track: Global
---

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document has a lot of Markdown errors. Please fix whatever the linter reports on.

Comment on lines +14 to +15
> A more detailed description of why the SCS has decided to use sonobuoys can be found on the corresponding [Decsision Record][sonbouy-decision-record].
> In addition, sonobuoy is also used as the toolset for executing Kubernetes very own [conformance tests][k8s-conformance].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a quote! (Same for the other "quotes" below.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add guidelines to write good conformance tests for K8S
2 participants